NVil Forum

General Category => Bug Reports => Topic started by: Vaquero on May 16, 2013, 12:56:21 am

Title: Composite Tool: Undo gets executed last
Post by: Vaquero on May 16, 2013, 12:56:21 am

The Undo command disregards the stack order and gets executed last, when put into the composite tool editor at some point.

Title: Re: Composite Tool: Undo gets executed last
Post by: IStonia on May 16, 2013, 10:47:09 am

Fixed.

Title: Re: Composite Tool: Undo gets executed last
Post by: Vaquero on May 16, 2013, 01:56:35 pm

Unfortunately I don't experiene the fix. Undo is still not executed at its position in the stack.
(http://i.imagebanana.com/img/pr32xibc/NVilCompTool_UndoBug.jpg)
In this illustrative example the extrude/bevel should be un-done and the poke should have its effect on the inset polygon.
The same happens to undo subobject selection.

Now to give an insight as to why someone would even use undo in the composite tool: I've come across a situation where I nested composite tools into another, but in the last iteration I didn't want the last step of the last composite tool, and go on from there.

Title: Re: Composite Tool: Undo gets executed last
Post by: IStonia on May 17, 2013, 09:28:08 am

It should be truly fixed now.

Title: Re: Composite Tool: Undo gets executed last
Post by: Vaquero on May 17, 2013, 02:28:28 pm

I hate to point it out, but... uhm, nope. :\
Undo now has the effect of deselecting components, but doesn't undo the last operation. This is easily tested by just putting extrude and undo into the stack and using the tool on a poly selection. Theoretically no changes would be visible.

And Undo subobject selection is still executed last:
(http://i.imagebanana.com/img/201nvony/NVilCompTool_UndoBug2.jpg)
In the image above, only the most inner polygons should have been extruded, since I'm undoing the grow selection command before extruding.

Title: Re: Composite Tool: Undo gets executed last
Post by: IStonia on May 18, 2013, 09:41:43 am

Fixed, again.

Title: Re: Composite Tool: Undo gets executed last
Post by: Vaquero on May 18, 2013, 01:47:42 pm

From what I can tell, "undo subobject selection" seems to work fine now, but "undo" still doesn't. I have "Keep Subobject Selections In Seperate Stack" enabled.

Title: Re: Composite Tool: Undo gets executed last
Post by: IStonia on May 18, 2013, 07:35:11 pm

I have tested your first undo bug composite tool sample and the undo works.

Title: Re: Composite Tool: Undo gets executed last
Post by: IStonia on May 19, 2013, 10:08:05 am

I have fixed another bug. Hopefully that's the one you mentioned.

Title: Re: Composite Tool: Undo gets executed last
Post by: Vaquero on May 19, 2013, 08:00:59 pm

I'm really sorry, that this seems to be such a difficult matter. I've made a video showing 2 bugs.
http://youtu.be/WSxYwsEgtKU (http://youtu.be/WSxYwsEgtKU)
Hopefully this is of some help.

Title: Re: Composite Tool: Undo gets executed last
Post by: IStonia on May 20, 2013, 11:24:40 am

Test it again?

Title: Re: Composite Tool: Undo gets executed last
Post by: Vaquero on May 20, 2013, 04:01:23 pm

All the scenarios I've tested now work, so I assume it's fixed. Thanks!